diff --git a/cores/arduino/wiring_digital.c b/cores/arduino/wiring_digital.c index 769bcaf79c8ac5d944d34cefd4e5a3f785973679..16d79e55e9cda7fac14d1ac56da308e4e39e4cfa 100644 --- a/cores/arduino/wiring_digital.c +++ b/cores/arduino/wiring_digital.c @@ -82,19 +82,23 @@ void digitalWrite( uint32_t ulPin, uint32_t ulVal ) return ; } - if ( (PORT->Group[g_APinDescription[ulPin].ulPort].DIRSET.reg & (1ul << g_APinDescription[ulPin].ulPin)) == 0 ) { + EPortType port = g_APinDescription[ulPin].ulPort; + uint32_t pin = g_APinDescription[ulPin].ulPin; + uint32_t pinMask = (1ul << pin); + + if ( (PORT->Group[port].DIRSET.reg & pinMask) == 0 ) { // the pin is not an output, disable pull-up if val is LOW, otherwise enable pull-up - PORT->Group[g_APinDescription[ulPin].ulPort].PINCFG[g_APinDescription[ulPin].ulPin].bit.PULLEN = (ulVal != LOW) ; + PORT->Group[port].PINCFG[pin].bit.PULLEN = (ulVal != LOW) ; } switch ( ulVal ) { case LOW: - PORT->Group[g_APinDescription[ulPin].ulPort].OUTCLR.reg = (1ul << g_APinDescription[ulPin].ulPin) ; + PORT->Group[port].OUTCLR.reg = pinMask; break ; default: - PORT->Group[g_APinDescription[ulPin].ulPort].OUTSET.reg = (1ul << g_APinDescription[ulPin].ulPin) ; + PORT->Group[port].OUTSET.reg = pinMask; break ; }