From 82be8b8e42116975d969880cf181a022783fd95d Mon Sep 17 00:00:00 2001
From: Oliver Sander <sander@igpm.rwth-aachen.de>
Date: Wed, 21 Feb 2007 11:12:59 +0000
Subject: [PATCH] cleanup and a bugfix in Dexp
[[Imported from SVN: r1220]]
---
src/quaternion.hh | 69 +++++++++++++++++++++++++++++++++++++++++++--
src/rodassembler.cc | 59 ++------------------------------------
src/rodassembler.hh | 4 ---
3 files changed, 69 insertions(+), 63 deletions(-)
diff --git a/src/quaternion.hh b/src/quaternion.hh
index 47832ee2..3de81c88 100644
--- a/src/quaternion.hh
+++ b/src/quaternion.hh
@@ -2,6 +2,7 @@
#define QUATERNION_HH
#include <dune/common/fvector.hh>
+#include <dune/common/fixedarray.hh>
#include <dune/common/fmatrix.hh>
#include <dune/common/exceptions.hh>
@@ -77,13 +78,14 @@ public:
Dune::FieldMatrix<T,4,3> result(0);
T norm = v.two_norm();
-
+
for (int i=0; i<3; i++) {
for (int m=0; m<3; m++) {
result[m][i] = (norm==0)
- ? (i==m)
+ /** \todo Isn't there a better way to implement this stably? */
+ ? 0.5 * (i==m)
: 0.5 * std::cos(norm/2) * v[i] * v[m] / (norm*norm) + sincHalf(norm) * ( (i==m) - v[i]*v[m]/(norm*norm));
}
@@ -131,6 +133,66 @@ public:
return d;
}
+ void getFirstDerivativesOfDirectors(Dune::FixedArray<Dune::FixedArray<Dune::FieldVector<double,3>, 3>, 3>& dd_dvj) const
+ {
+ const Quaternion<T>& q = (*this);
+
+ // Contains \partial q / \partial v^i_j at v = 0
+ Dune::FixedArray<Quaternion<double>,3> dq_dvj;
+ for (int j=0; j<3; j++) {
+ for (int m=0; m<4; m++)
+ dq_dvj[j][m] = (j==m) * 0.5;
+ }
+
+ // Contains \parder d \parder v_j
+
+ for (int j=0; j<3; j++) {
+
+ // d1
+ dd_dvj[0][j][0] = q[0]*(q.mult(dq_dvj[j]))[0] - q[1]*(q.mult(dq_dvj[j]))[1]
+ - q[2]*(q.mult(dq_dvj[j]))[2] + q[3]*(q.mult(dq_dvj[j]))[3];
+
+ dd_dvj[0][j][1] = (q.mult(dq_dvj[j]))[0]*q[1] + q[0]*(q.mult(dq_dvj[j]))[1]
+ + (q.mult(dq_dvj[j]))[2]*q[3] + q[2]*(q.mult(dq_dvj[j]))[3];
+
+ dd_dvj[0][j][2] = (q.mult(dq_dvj[j]))[0]*q[2] + q[0]*(q.mult(dq_dvj[j]))[2]
+ - (q.mult(dq_dvj[j]))[1]*q[3] - q[1]*(q.mult(dq_dvj[j]))[3];
+
+ // d2
+ dd_dvj[1][j][0] = (q.mult(dq_dvj[j]))[0]*q[1] + q[0]*(q.mult(dq_dvj[j]))[1]
+ - (q.mult(dq_dvj[j]))[2]*q[3] - q[2]*(q.mult(dq_dvj[j]))[3];
+
+ dd_dvj[1][j][1] = - q[0]*(q.mult(dq_dvj[j]))[0] + q[1]*(q.mult(dq_dvj[j]))[1]
+ - q[2]*(q.mult(dq_dvj[j]))[2] + q[3]*(q.mult(dq_dvj[j]))[3];
+
+ dd_dvj[1][j][2] = (q.mult(dq_dvj[j]))[1]*q[2] + q[1]*(q.mult(dq_dvj[j]))[2]
+ + (q.mult(dq_dvj[j]))[0]*q[3] + q[0]*(q.mult(dq_dvj[j]))[3];
+
+ // d3
+ dd_dvj[2][j][0] = (q.mult(dq_dvj[j]))[0]*q[2] + q[0]*(q.mult(dq_dvj[j]))[2]
+ + (q.mult(dq_dvj[j]))[1]*q[3] + q[1]*(q.mult(dq_dvj[j]))[3];
+
+ dd_dvj[2][j][1] = (q.mult(dq_dvj[j]))[1]*q[2] + q[1]*(q.mult(dq_dvj[j]))[2]
+ - (q.mult(dq_dvj[j]))[0]*q[3] - q[0]*(q.mult(dq_dvj[j]))[3];
+
+ dd_dvj[2][j][2] = - q[0]*(q.mult(dq_dvj[j]))[0] - q[1]*(q.mult(dq_dvj[j]))[1]
+ + q[2]*(q.mult(dq_dvj[j]))[2] + q[3]*(q.mult(dq_dvj[j]))[3];
+
+
+ dd_dvj[0][j] *= 2;
+ dd_dvj[1][j] *= 2;
+ dd_dvj[2][j] *= 2;
+
+ }
+
+ // Check: The derivatives of the directors must be orthogonal to the directors
+ for (int i=0; i<3; i++)
+ for (int j=0; j<3; j++)
+ assert (std::abs(q.director(i) * dd_dvj[i][j]) < 1e-7);
+
+}
+
+
/** \brief Turn quaternion into a unit quaternion by dividing by its Euclidean norm */
void normalize() {
(*this) /= this->two_norm();
@@ -221,6 +283,9 @@ public:
result = a.mult(result);
+ // ////////////////////////////////////////////////////////////////////////////
+ // Check correctness by comparing with a finite difference approximation
+ // ////////////////////////////////////////////////////////////////////////////
double eps = 1e-6;
Quaternion<T> fdResult = interpolate(a,b, omega+eps);
fdResult -= interpolate(a,b, omega-eps);
diff --git a/src/rodassembler.cc b/src/rodassembler.cc
index 740ba584..165867ee 100644
--- a/src/rodassembler.cc
+++ b/src/rodassembler.cc
@@ -93,61 +93,6 @@ assembleMatrix(const std::vector<Configuration>& sol,
}
-template <class GridType>
-void Dune::RodAssembler<GridType>::
-getFirstDerivativesOfDirectors(const Quaternion<double>& q,
- Dune::FixedArray<Dune::FixedArray<Dune::FieldVector<double,3>, 3>, 3>& dd_dvj,
- const Dune::FixedArray<Quaternion<double>, 3>& dq_dvj)
-{
-
- // Contains \parder d \parder v_j
-
- for (int j=0; j<3; j++) {
-
- // d1
- dd_dvj[0][j][0] = q[0]*(q.mult(dq_dvj[j]))[0] - q[1]*(q.mult(dq_dvj[j]))[1]
- - q[2]*(q.mult(dq_dvj[j]))[2] + q[3]*(q.mult(dq_dvj[j]))[3];
-
- dd_dvj[0][j][1] = (q.mult(dq_dvj[j]))[0]*q[1] + q[0]*(q.mult(dq_dvj[j]))[1]
- + (q.mult(dq_dvj[j]))[2]*q[3] + q[2]*(q.mult(dq_dvj[j]))[3];
-
- dd_dvj[0][j][2] = (q.mult(dq_dvj[j]))[0]*q[2] + q[0]*(q.mult(dq_dvj[j]))[2]
- - (q.mult(dq_dvj[j]))[1]*q[3] - q[1]*(q.mult(dq_dvj[j]))[3];
-
- // d2
- dd_dvj[1][j][0] = (q.mult(dq_dvj[j]))[0]*q[1] + q[0]*(q.mult(dq_dvj[j]))[1]
- - (q.mult(dq_dvj[j]))[2]*q[3] - q[2]*(q.mult(dq_dvj[j]))[3];
-
- dd_dvj[1][j][1] = - q[0]*(q.mult(dq_dvj[j]))[0] + q[1]*(q.mult(dq_dvj[j]))[1]
- - q[2]*(q.mult(dq_dvj[j]))[2] + q[3]*(q.mult(dq_dvj[j]))[3];
-
- dd_dvj[1][j][2] = (q.mult(dq_dvj[j]))[1]*q[2] + q[1]*(q.mult(dq_dvj[j]))[2]
- + (q.mult(dq_dvj[j]))[0]*q[3] + q[0]*(q.mult(dq_dvj[j]))[3];
-
- // d3
- dd_dvj[2][j][0] = (q.mult(dq_dvj[j]))[0]*q[2] + q[0]*(q.mult(dq_dvj[j]))[2]
- + (q.mult(dq_dvj[j]))[1]*q[3] + q[1]*(q.mult(dq_dvj[j]))[3];
-
- dd_dvj[2][j][1] = (q.mult(dq_dvj[j]))[1]*q[2] + q[1]*(q.mult(dq_dvj[j]))[2]
- - (q.mult(dq_dvj[j]))[0]*q[3] - q[0]*(q.mult(dq_dvj[j]))[3];
-
- dd_dvj[2][j][2] = - q[0]*(q.mult(dq_dvj[j]))[0] - q[1]*(q.mult(dq_dvj[j]))[1]
- + q[2]*(q.mult(dq_dvj[j]))[2] + q[3]*(q.mult(dq_dvj[j]))[3];
-
-
- dd_dvj[0][j] *= 2;
- dd_dvj[1][j] *= 2;
- dd_dvj[2][j] *= 2;
-
- }
-
- // Check: The derivatives of the directors must be orthogonal to the directors
- for (int i=0; i<3; i++)
- for (int j=0; j<3; j++)
- assert (std::abs(q.director(i) * dd_dvj[i][j]) < 1e-7);
-
-}
-
template <class GridType>
template <class MatrixType>
@@ -263,7 +208,7 @@ getLocalMatrix( EntityPointer &entity,
// Contains \parder d \parder v^i_j
FixedArray<FixedArray<FieldVector<double,3>, 3>, 3> dd_dvj;
- getFirstDerivativesOfDirectors(q, dd_dvj, dq_dvj);
+ q.getFirstDerivativesOfDirectors(dd_dvj);
// Contains \parder {dm}{v^i_j}{v^k_l}
FieldVector<double,3> dd_dvij_dvkl[3][3][3];
@@ -526,7 +471,7 @@ assembleGradient(const std::vector<Configuration>& sol,
// dd_dvij[k][i][j] = \parder {d_k} {v^i_j}
FixedArray<FixedArray<FieldVector<double,3>, 3>, 3> dd_dvj;
- getFirstDerivativesOfDirectors(hatq, dd_dvj, dq_dvj);
+ hatq.getFirstDerivativesOfDirectors(dd_dvj);
// /////////////////////////////////////////////
diff --git a/src/rodassembler.hh b/src/rodassembler.hh
index 985c975f..9d1678f2 100644
--- a/src/rodassembler.hh
+++ b/src/rodassembler.hh
@@ -149,10 +149,6 @@ namespace Dune
return u;
}
- static void getFirstDerivativesOfDirectors(const Quaternion<double>& q,
- Dune::FixedArray<Dune::FixedArray<Dune::FieldVector<double,3>, 3>, 3>& dd_dvj,
- const Dune::FixedArray<Quaternion<double>, 3>& dq_dvj);
-
}; // end class
} // end namespace
--
GitLab