Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • A amdis-core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Graph
    • Compare revisions
  • Issues 6
    • Issues 6
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 6
    • Merge requests 6
  • Deployments
    • Deployments
    • Releases
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • amdis
  • amdis-core
  • Merge requests
  • !147

Wrap DistributedCommunication::RemoteIndices in unique_ptr to fix move issue in c++14

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Müller, Felix requested to merge issue/petsc_comm_move into master Jan 24, 2020
  • Overview 0
  • Commits 1
  • Changes 1

Due to missing copy elision in c++14 the PETSc Comm object DistributedCommunication is required to have a copy or move constructor in the statement (ParallelGlobalBasis.hpp:89)

    , comm_(CommunicationCreator<Comm>::create(static_cast<Super const&>(*this), name + "->solver"))

Since the member Dune::RemoteIndices declares a private copy and no move constructor we need to wrap it into a unique_ptr to provide move semantics.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: issue/petsc_comm_move