Global DOF IDs

added 1 commit

8d90ea21 - corrected the unbind function

Compare with previous version

added 1 commit

0f366d3d - wrong unbind function call corrected

Compare with previous version

added 1 commit

43b395c2 - Added partition type query to GlobalIdSet

Compare with previous version

There is an issue with NodeIdSet<PowerPreBasis> right now. It only binds to the first node, which makes certain calls (like node.localIndex(...)) return wrong results.

We could basically copy-paste the implementation from NodeIdSet<CompositePreBasis>, however this would be likely inefficient since we have a homogeneous type of PowerPreBases. Is there some array-like structure that allows constructing from arguments, like below?

  protected:
    using SubPreBasis = typename PreBasis::SubPreBasis;
    using SubTreePath = decltype(Dune::TypeTree::push_back(std::declval<TP>(), std::size_t{}));
    using SubNodeIdSet = SomeContainer<NodeIdSet<SubPreBasis, SubTreePath>, C>;
    static const std::size_t children = C;

  public:
    NodeIdSet(GridView const& gridView)
      : subIds_(gridView) // initializes C objects
    {}

    /// \brief Bind the view to a grid element
    void bind(const Node& node)
    {
      node_ = &node;
-     subIds_.bind(node.child(0));
+     for (std::size_t i = 0; i < children; ++i)
+       subIds_[i].bind(node.child(i));
    }

    ...

    /// Maps from subtree index set [0..size-1] to a globally unique id in global basis
    template <class It>
    It fillIn(It it, size_type shift = 0) const
    {
      for (std::size_t i = 0; i < children; ++i)
      {
        size_type subTreeSize = subIds_.size();
-       it = subIds_.fillIn(it, shift);
+       it = subIds_[i].fillIn(it, shift);
        shift += subTreeSize;
      }
      return it;
    }