improve tests (error)

Check in tests whether error really was written, by setting it to
undefined before each call.

src/error.h

@@ -28,6 +28,7 @@
 
 enum SH_ErrorType
 {
+	UNDEFINED,
 	ALLOCATION_FAILED,
 	DOMAIN_ERROR,
 	VALUE_ERROR,

tests/test_cms.c

@@ -39,10 +39,12 @@ START_TEST(test_cms)
 
 	SH_Cms_free (cms, NULL);
 
+	error.type = UNDEFINED;
 	cms = SH_Cms_new (&error);
 	ck_assert_int_ne ((long int) cms, (long int) NULL);
 	ck_assert_int_eq (error.type, SUCCESS);
 
+	error.type = UNDEFINED;
 	SH_Cms_free (cms, &error);
 	ck_assert_int_eq (error.type, SUCCESS);
 }

tests/test_data.c

@@ -42,6 +42,7 @@ START_TEST(test_data)
 
 	SH_Data_free (data, NULL);
 
+	error.type = UNDEFINED;
 	data = SH_Data_new (&error);
 	ck_assert_int_ne ((long int) data, (long int) NULL);
 	ck_assert_int_eq (error.type, SUCCESS);
@@ -49,6 +50,7 @@ START_TEST(test_data)
 	ck_assert_int_eq (data->page_n, 0);
 	ck_assert_int_eq (data->last_page, PAGE_ERR);
 
+	error.type = UNDEFINED;
 	SH_Data_free (data, &error);
 	ck_assert_int_eq (error.type, SUCCESS);
 }
@@ -99,6 +101,8 @@ START_TEST(test_data_register_page)
 
 	/* success with error */
 	data->last_page = 1;
+
+	error.type = UNDEFINED;
 	page = SH_Data_register_page (data, page4, &error);
 	ck_assert_int_eq (page, 2);
 	ck_assert_int_eq (error.type, SUCCESS);
@@ -112,6 +116,7 @@ START_TEST(test_data_register_page)
 	/* fail with error */
 	data->page_n = UINT_MAX;
 
+	error.type = UNDEFINED;
 	page = SH_Data_register_page (data, page5, &error);
 	ck_assert_int_eq (page, PAGE_ERR);
 	ck_assert_int_eq (error.type, DOMAIN_ERROR);
@@ -123,6 +128,7 @@ START_TEST(test_data_register_page)
 	data->page_n = 2;
 	data->last_page = PAGE_MAX;
 
+	error.type = UNDEFINED;
 	page = SH_Data_register_page (data, page6, &error);
 	ck_assert_int_eq (page, PAGE_ERR);
 	ck_assert_int_eq (error.type, DOMAIN_ERROR);

tests/test_fragment.c

@@ -53,16 +53,19 @@ START_TEST(test_fragment)
 	ck_assert_int_eq ((long int) fragment, (long int) NULL);
 
 	/* valid tag - error */
+	error.type = UNDEFINED;
 	fragment = SH_Fragment_new (tag, data, &error);
 	ck_assert_int_ne ((long int) fragment, (long int) NULL);
 	ck_assert_int_eq (error.type, SUCCESS);
 
 	ck_assert_str_eq (fragment->tag, tag);
 
+	error.type = UNDEFINED;
 	SH_Fragment_free (fragment, &error);
 	ck_assert_int_eq (error.type, SUCCESS);
 
 	/* invalid tag - error */
+	error.type = UNDEFINED;
 	fragment = SH_Fragment_new (no_tag, data, &error);
 	ck_assert_int_eq ((long int) fragment, (long int) NULL);
 	ck_assert_int_eq (error.type, VALUE_ERROR);
@@ -96,6 +99,7 @@ START_TEST(test_fragment_tag)
 	/* error */
 	fragment = SH_Fragment_new (tag2, data, NULL);
 
+	error.type = UNDEFINED;
 	tag = SH_Fragment_get_tag (fragment, &error);
 	ck_assert_str_eq (tag, tag2);
 	ck_assert_int_eq (error.type, SUCCESS);

tests/test_text.c

@@ -39,10 +39,12 @@ START_TEST(test_text)
 
 	SH_Text_free (text, NULL);
 
+	error.type = UNDEFINED;
 	text = SH_Text_new (&error);
 	ck_assert_int_ne ((long int) text, (long int) NULL);
 	ck_assert_int_eq (error.type, SUCCESS);
 
+	error.type = UNDEFINED;
 	SH_Text_free (text, &error);
 	ck_assert_int_eq (error.type, SUCCESS);
 }

tests/test_validator.c

@@ -52,10 +52,12 @@ START_TEST(test_validator)
 
 	SH_Validator_free (validator, NULL);
 
+	error.type = UNDEFINED;
 	validator = SH_Validator_new (&error);
 	ck_assert_int_ne ((long int) validator, (long int) NULL);
 	ck_assert_int_eq (error.type, SUCCESS);
 
+	error.type = UNDEFINED;
 	SH_Validator_free (validator, &error);
 	ck_assert_int_eq (error.type, SUCCESS);
 }
@@ -145,6 +147,8 @@ START_TEST(test_validator_tag)
 
 	/* success with error */
 	validator->last_tag = 1;
+
+	error.type = UNDEFINED;
 	tag = SH_Validator_register_tag (validator, tag4, &error);
 	ck_assert_int_eq (tag, 2);
 	ck_assert_int_eq (error.type, SUCCESS);
@@ -178,6 +182,7 @@ START_TEST(test_validator_tag)
 		SH_Validator_register_tag (validator, tagN, NULL);
 	}
 
+	error.type = UNDEFINED;
 	tag = SH_Validator_register_tag (validator, tag5, &error);
 	ck_assert_int_eq (tag, TAG_ERR);
 	ck_assert_int_eq (error.type, DOMAIN_ERROR);
@@ -192,6 +197,7 @@ START_TEST(test_validator_tag)
 	validator->tag_n = 2;
 	validator->last_tag = TAG_MAX;
 
+	error.type = UNDEFINED;
 	tag = SH_Validator_register_tag (validator, tag6, &error);
 	ck_assert_int_eq (tag, TAG_ERR);
 	ck_assert_int_eq (error.type, DOMAIN_ERROR);