Skip to content
Snippets Groups Projects
  1. Mar 17, 2023
  2. Mar 16, 2023
    • Jonathan Schöbel's avatar
      NodeFragment: added remove methods · 8d84e3c7
      Jonathan Schöbel authored
      Various remove methods were added, which are all implemented by an
      static method, analog to the last commit.
      8d84e3c7
    • Jonathan Schöbel's avatar
      NodeFragment: improved insert methods · 1e575a13
      Jonathan Schöbel authored
      The single method (formerly SH_NodeFragment_append_child) to add a child
      at the end of the child list was replaced, by a bunch of methods to
      insert a child at the beginning (SH_NodeFragment_prepend_child), at the
      end (SH_NodeFragment_append_child), at a specific position
      (SH_NodeFragment_insert_child) and directly before
      (SH_NodeFragment_insert_child_before) or after another child
      (SH_NodeFragment_insert_child_after). All these methods are implemented
      by a single internal one (insert_child), as there isn't really much
      difference in inserting one or the other way.
      But this internal method doesn't check whether this insertion request is
      actually doable, to save overhead as not every insertion method requires
      this check. This is done by the respective method. However if the check
      is not done correctly the internal method will attempt to write at not
      allocated space, which will hopefully result in a segfault.
      
      The child list is implemented as an array. To reduce the overhead to
      realloc calls, the array is allocated in chunks of childs. The
      calculation how many has to be allocated is done by another static
      method and determined by the macro CHILD_CHUNK. This is set to 5, which
      is just a guess. It should be somewhere around the average number of
      childs per html element, to reduce unused overhead.
      
      Also some predicates (SH_NodeFragment_is_parent,
      SH_NodeFragment_is_ancestor) were added to check whether a relationship
      exists between to nodes, thus whether they are linked through one or
      multiple levels. These functions could replace the old ones
      (SH_NodeFragment_is_child, SH_NodeFragment_is_descendant) semantically.
      Furthermore they are more efficient as this is now possible to check
      over the parent pointer. The internal insert method also uses these
      methods to check whether the child node is actually a parent of the
      parent node, which would result in errors later one.
      
      The old test is now obsolete but remained, as it is not bad to test
      more.
      1e575a13
  3. Mar 13, 2023
    • Jonathan Schöbel's avatar
      fixup! implement NodeFragment as Fragment · 95051add
      Jonathan Schöbel authored
      Removed some unnecessary type casts.
      Added some forgotten calls to free.
      95051add
    • Jonathan Schöbel's avatar
      Fragment: added parent · 92ed2019
      Jonathan Schöbel authored
      Every fragment has a parent now, this is useful for both traversing the
      tree and checking for cycles when a node is added, which would cause
      problems, like freeing things twice or similar nice bugs. Both wouldn't
      be possible otherwise. These features are not implemented yet.
      92ed2019
    • Jonathan Schöbel's avatar
      NodeFragment: added unsafe getter for tag · 0bab1f50
      Jonathan Schöbel authored
      The library provides a way to directly access the tag in a read-only
      way, which saves an call to strdup. This is useful if only reading is
      necessary , but needs special care by developers, as it is neither
      allowed to modify it nor to free it. Disregarding this will lead to a
      segfault in the best, and to silent data corruption and security bugs in
      the worst case.
      0bab1f50
  4. Jan 09, 2023
  5. Jan 06, 2023
  6. Jan 05, 2023
  7. Jan 04, 2023
  8. Nov 24, 2022
  9. Nov 23, 2022
    • Jonathan Schöbel's avatar
      Validator: added copy method · 0aca3965
      Jonathan Schöbel authored
      Copying a Validator could be useful if multiple html versions are to be
      supported. Another use case is a blacklist XSS-Scanner.
      0aca3965
    • Jonathan Schöbel's avatar
      Validator: deregister tag · 95ba8a94
      Jonathan Schöbel authored
      A registered tag can be deregistered by calling SH_Validator_deregister.
      The data is removed, but the space is not deallocated, if it is not at
      the end. This prevents copying data on removal and saves expensive calls
      to realloc. Instead the empty space is added to the list of free blocks,
      which allows to refill these spaces, if a new tag is being registered.
      The space is finally deallocated, if the validator is being deallocated
      or the tag written in the last block is removed. In this case, heavy
      iteration is performed, as the list of free blocks is not ordered. The
      next last tag at that time is determined by iterating over the list of
      free blocks until some it is not found.
      Note that even if there can be a lot of gaps in between, the Validator
      will not allocate more space until all these gaps are refilled when a
      new tag is registered, thus new space is only being allocated, if there
      is really not enough space left.
      Due to the 4 nested loops, there was an issue related to the
      72(80)-column rule. It can't be abided without severely impacting the
      readability of the code.
      95ba8a94
  10. Nov 17, 2022
  11. Nov 16, 2022
    • Jonathan Schöbel's avatar
      Validator: restructured internal data · a0c9bb25
      Jonathan Schöbel authored
      The Validator saves the tags as an array. Now also another information
      is added, which slots aren't used currently to spare expensive calls to
      realloc. This led to a mere reimplementation of the functions. Tags
      can't be deleted by now, but the adding function supports reusing empty
      slots. Also the reading functions have to determine, whether a slot can
      be read or is empty.
      The tests were adjusted, but are buggy, so they should be rewritten in
      the future.
      
      Additionaly some annotations for splint were added.
      a0c9bb25
  12. Nov 15, 2022
    • Jonathan Schöbel's avatar
      API change: error -> status for exception handling · 0e0fa194
      Jonathan Schöbel authored
      Instead of the trivial structure SH_Error, SH_Status is used. The name
      was chosen, because error/status is set independently whether an error
      has occurred. Beside the error type, it also contains the associated
      errno and an error message. The error message is also printed, when it
      is set. Generating error messages with variadic arguments is now also
      supported.
      There are also macros to check for a set status.
      
      The exception handling was removed for the *_free methods, because they
      can't fail predictably during runtime.
      
      Unfortunately the compiler reports, that inside the macro set_status
      printf may be called with NULL [printf (NULL)], although, this is
      explicitly debarred.
      0e0fa194
  13. Oct 17, 2022
    • Jonathan Schöbel's avatar
      setup library (make & API) · f86bd5cf
      Jonathan Schöbel authored
      The make process was restructured to create a library. For this libtool
      is used to provide both static and dynamic linking. Also header
      inclusion guards were introduced, to prevent clients of the library to
      include some single file without including others. The types were
      exported with forward declarations for better abstraction. When
      compiling the library, the macro LIB_SEFHT_COMPILATION is defined and
      symbol declarations are exported fully. For compiling the tests this
      macro is also defined, as the tests not only tests the API, but also the
      internal state, because a lot of errors couldn't be detected otherwise.
      f86bd5cf
    • Jonathan Schöbel's avatar
      65bfbab2
    • Jonathan Schöbel's avatar
      Merge branch 'feature/text' · 548398ff
      Jonathan Schöbel authored
      548398ff
  14. Oct 16, 2022
    • Jonathan Schöbel's avatar
      Text: trivial print · ee0a2189
      Jonathan Schöbel authored
      The method SH_Text_print just prints the whole string to stdout.
      ee0a2189
    • Jonathan Schöbel's avatar
      Text: get length · eca6e0ab
      Jonathan Schöbel authored
      The function SH_Text_get_length returns the length of the text. As the
      text also supports being longer than SIZE_MAX, this method can fail on
      runtime. If the text is longer then SIZE_MAX, the Text returns SIZE_MAX
      and sets error to DOMAIN_ERROR. Note, that due to the implementation,
      this is a non trivial function, so don't use it to exhaustively.
      eca6e0ab
  15. Oct 15, 2022
    • Jonathan Schöbel's avatar
      Text: fetch range · bacd41a4
      Jonathan Schöbel authored
      The function SH_Text_get_range returns a string begining at start and
      ending at end. Note that end specifies the char, that is not returned
      anymore. Thus the function implements something similar, as the pythonic
      slice syntax (text[start:end]). In opposition to the behaviour there,
      calling SH_Text_get_range with start > end is undefined behaviour. If
      start == end, the empty string is returned.
      If start is out of bounds, NULL is returned and an error is set. If end
      is out of bounds, the existent part is returned. Also the length of the
      returned string can be set (optionally) to the out parameter length.
      bacd41a4
Loading