Skip to content
Snippets Groups Projects
Commit 7c845895 authored by Cristian Maglie's avatar Cristian Maglie Committed by Cristian Maglie
Browse files

Fixed analogWriteResolution behaviour

parent daf34ae9
No related branches found
No related tags found
No related merge requests found
...@@ -194,11 +194,6 @@ uint32_t analogRead( uint32_t ulPin ) ...@@ -194,11 +194,6 @@ uint32_t analogRead( uint32_t ulPin )
void analogWrite( uint32_t ulPin, uint32_t ulValue ) void analogWrite( uint32_t ulPin, uint32_t ulValue )
{ {
uint32_t attr = g_APinDescription[ulPin].ulPinAttribute ; uint32_t attr = g_APinDescription[ulPin].ulPinAttribute ;
// uint32_t pwm_name = g_APinDescription[ulPin].ulTCChannel ;
uint8_t isTC = 0 ;
uint8_t Channelx ;
Tc* TCx = 0 ;
Tcc* TCCx = 0 ;
if ( (attr & PIN_ATTR_ANALOG) == PIN_ATTR_ANALOG ) if ( (attr & PIN_ATTR_ANALOG) == PIN_ATTR_ANALOG )
{ {
...@@ -207,10 +202,12 @@ void analogWrite( uint32_t ulPin, uint32_t ulValue ) ...@@ -207,10 +202,12 @@ void analogWrite( uint32_t ulPin, uint32_t ulValue )
return; return;
} }
ulValue = mapResolution(ulValue, _writeResolution, 10);
syncDAC(); syncDAC();
DAC->DATA.reg = ulValue & 0x3FF; // DAC on 10 bits. DAC->DATA.reg = ulValue & 0x3FF; // DAC on 10 bits.
syncDAC(); syncDAC();
DAC->CTRLA.bit.ENABLE = 0x01; //Enable ADC DAC->CTRLA.bit.ENABLE = 0x01; // Enable DAC
syncDAC(); syncDAC();
return ; return ;
} }
...@@ -222,15 +219,15 @@ void analogWrite( uint32_t ulPin, uint32_t ulValue ) ...@@ -222,15 +219,15 @@ void analogWrite( uint32_t ulPin, uint32_t ulValue )
pinPeripheral( ulPin, g_APinDescription[ulPin].ulPinType ) ; pinPeripheral( ulPin, g_APinDescription[ulPin].ulPinType ) ;
} }
Channelx = GetTCChannelNumber( g_APinDescription[ulPin].ulPWMChannel ) ; Tc* TCx = 0 ;
Tcc* TCCx = 0 ;
uint8_t Channelx = GetTCChannelNumber( g_APinDescription[ulPin].ulPWMChannel ) ;
if ( GetTCNumber( g_APinDescription[ulPin].ulPWMChannel ) >= TCC_INST_NUM ) if ( GetTCNumber( g_APinDescription[ulPin].ulPWMChannel ) >= TCC_INST_NUM )
{ {
isTC = 1 ;
TCx = (Tc*) GetTC( g_APinDescription[ulPin].ulPWMChannel ) ; TCx = (Tc*) GetTC( g_APinDescription[ulPin].ulPWMChannel ) ;
} }
else else
{ {
isTC = 0 ;
TCCx = (Tcc*) GetTC( g_APinDescription[ulPin].ulPWMChannel ) ; TCCx = (Tcc*) GetTC( g_APinDescription[ulPin].ulPWMChannel ) ;
} }
...@@ -264,12 +261,14 @@ void analogWrite( uint32_t ulPin, uint32_t ulValue ) ...@@ -264,12 +261,14 @@ void analogWrite( uint32_t ulPin, uint32_t ulValue )
break ; break ;
} }
ulValue = mapResolution(ulValue, _writeResolution, 8);
// Set PORT // Set PORT
if ( isTC ) if ( TCx )
{ {
// -- Configure TC // -- Configure TC
// DISABLE TCx // Disable TCx
TCx->COUNT8.CTRLA.reg &=~(TC_CTRLA_ENABLE); TCx->COUNT8.CTRLA.reg &= ~TC_CTRLA_ENABLE;
// Set Timer counter Mode to 8 bits // Set Timer counter Mode to 8 bits
TCx->COUNT8.CTRLA.reg |= TC_CTRLA_MODE_COUNT8; TCx->COUNT8.CTRLA.reg |= TC_CTRLA_MODE_COUNT8;
// Set TCx as normal PWM // Set TCx as normal PWM
...@@ -284,16 +283,15 @@ void analogWrite( uint32_t ulPin, uint32_t ulValue ) ...@@ -284,16 +283,15 @@ void analogWrite( uint32_t ulPin, uint32_t ulValue )
else else
{ {
// -- Configure TCC // -- Configure TCC
// Disable TCCx
// DISABLE TCCx TCCx->CTRLA.reg &= ~TCC_CTRLA_ENABLE;
TCCx->CTRLA.reg &=~(TCC_CTRLA_ENABLE);
// Set TCx as normal PWM // Set TCx as normal PWM
TCCx->WAVE.reg |= TCC_WAVE_WAVEGEN_NPWM; TCCx->WAVE.reg |= TCC_WAVE_WAVEGEN_NPWM;
// Set TCx in waveform mode Normal PWM // Set TCx in waveform mode Normal PWM
TCCx->CC[Channelx].reg = (uint32_t)ulValue; TCCx->CC[Channelx].reg = (uint32_t)ulValue;
// Set PER to maximum counter value (resolution : 0xFF) // Set PER to maximum counter value (resolution : 0xFF)
TCCx->PER.reg = 0xFF; TCCx->PER.reg = 0xFF;
// ENABLE TCCx // Enable TCCx
TCCx->CTRLA.reg |= TCC_CTRLA_ENABLE ; TCCx->CTRLA.reg |= TCC_CTRLA_ENABLE ;
} }
...@@ -302,9 +300,7 @@ void analogWrite( uint32_t ulPin, uint32_t ulValue ) ...@@ -302,9 +300,7 @@ void analogWrite( uint32_t ulPin, uint32_t ulValue )
// -- Defaults to digital write // -- Defaults to digital write
pinMode( ulPin, OUTPUT ) ; pinMode( ulPin, OUTPUT ) ;
ulValue = mapResolution(ulValue, _writeResolution, 8); ulValue = mapResolution(ulValue, _writeResolution, 8);
if ( ulValue < 128 ) if ( ulValue < 128 )
{ {
digitalWrite( ulPin, LOW ) ; digitalWrite( ulPin, LOW ) ;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment